On Fri, Mar 20, 2026, Baolin Wang wrote:
> > > -static __always_inline int kvm_age_hva_range(struct mmu_notifier *mn,
> > > -                                         unsigned long start,
> > > -                                         unsigned long end,
> > > -                                         gfn_handler_t handler,
> > > -                                         bool flush_on_ret)
> > > +static __always_inline bool kvm_age_hva_range(struct mmu_notifier *mn,
> > > +                                       unsigned long start,
> > > +                                       unsigned long end,
> > > +                                       gfn_handler_t handler,
> > > +                                       bool flush_on_ret)
> > 
> > Can we please fix this terrrible indentation while we're here :)?
> > 
> > static __always_inline bool kvm_age_hva_range(struct mmu_notifier *mn,
> >             unsigned long start, unsigned long end, gfn_handler_t handler,
> >             bool flush_on_ret)
> > 
> > Would be nicer, thanks!

No, please keep this as-is.  KVM's preferred style is exactly this (and I 
personally
find mm's style much harder to parse).

Reply via email to