Adrian Bunk wrote: > On Mon, Oct 13, 2008 at 03:45:59PM +0530, Kamalesh Babulal wrote: >> Hi, >> >> 2.6.27-git2 kernel build fails, while building the kernel with
from subject, on PPC. >> allyesconfig option. The allyesconfig selects CONFIG_INTEL_IOATDMA=y >> >> CC drivers/dma/ioat_dca.o >> drivers/dma/ioat_dca.c: In function âdca_enabled_in_biosâ: >> drivers/dma/ioat_dca.c:81: error: implicit declaration of function >> âcpuid_eaxâ drivers/dma/ioat_dca.c: In function >> âsystem_has_dca_enabledâ: >> drivers/dma/ioat_dca.c:91: error: implicit declaration of function >> âboot_cpu_hasâ drivers/dma/ioat_dca.c:91: error: >> âX86_FEATURE_DCAâ undeclared (first use in this function) >> drivers/dma/ioat_dca.c:91: error: (Each undeclared identifier is >> reported only once drivers/dma/ioat_dca.c:91: error: for each >> function it appears in.) >> drivers/dma/ioat_dca.c: In function âioat_dca_get_tagâ: >> drivers/dma/ioat_dca.c:190: error: implicit declaration of function >> âcpu_physical_idâ make[2]: *** [drivers/dma/ioat_dca.o] Error 1 >> make[1]: *** [drivers/dma] Error 2 >> make: *** [drivers] Error 2 >> ... > > Thanks for the report, the MYRI10GE and IXGBE commits that introduced > the select's are really broken. it fixed an obvious bug with CONFIG_IXGBE=y and CONFIG_INTEL_IOATDMA=m, unfortunate that it is so difficult to use Kconfig for the uninitiated. > For fixing it I need to know the intended semantics. > > Brian, Jesse, is it OK to limit the drivers to m with > CONFIG_INTEL_IOATDMA=m ? why is the IOATDMA driver not depending on x86? x86 hardware (32 and 64 bit) are the only machines that will have ioatdma support, since the ioatdma (and dca) device is only in Intel server chipsets since S5000 (aka S5000, S5400, S7400 and derivatives/followons) What we want, is myri10ge and ixgbe drivers that can build whether or not CONFIG_INTEL_IOATDMA is enabled. IF CONFIG_INTEL_IOATDMA *is* enabled (which it should not be on PPC) then there are several cases we want to work: CONFIG_INTEL_IOATDMA=m ---> CONFIG_IXGBE=[m|n] CONFIG_INTEL_IOATDMA=y ---> CONFIG_IXGBE=[m|y|n] CONFIG_INTEL_IOATDMA=n ---> CONFIG_IXGBE=[m|y|n] CONFIG_INTEL_IOATDMA depends on X86 same for myri10ge I think. I hope that cleared something up, we can seriously use some help from the experts to get Kconfig correct for this. _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
