>-----Original Message----- >From: Paul Mackerras [mailto:[EMAIL PROTECTED] >Sent: Friday, October 10, 2008 1:14 PM >To: [EMAIL PROTECTED] >Cc: Arnd Bergmann; [EMAIL PROTECTED]; Sadashiiv, Halesh; >linuxppc-dev@ozlabs.org >Subject: Re: [PATCH] remove bogus ppc_select syscall > >Benjamin Herrenschmidt writes: > >> On Wed, 2008-09-24 at 08:39 +0200, Arnd Bergmann wrote: >> > The ppc_select function was introduced in linux-2.3.48 in order to >support >> > code confusing the legacy select() calling convention with the standard >one. >> > Even 11 years ago, all correctly built code should not have done this >and >> > could have easily been phased out. Nothing that was compiled later >should >> > actually try to use the old_select interface, and it would have been >broken >> > already on all ppc64 kernels with the syscall emulation layer. >> > >> > This patch brings the 32 bit compat ABI and the native 32 bit ABI for >> > powerpc into a consistent state, by removing support for both the >> > old_select system call number and the handler for it. >> >> .../... >> >> It's me or the patch is whitespaces damaged ? > >Please don't apply Arnd's patch. As I said, all we need is this >one-line change in arch/powerpc/include/asm/systbl.h: > >-SYSX_SPU(sys_select,ppc32_select,ppc_select) >+SYSX_SPU(sys_select,ppc32_select,sys_select)
I have tested the testcase that I have provided at the time of reporting this issue. But it didn't work as expected with the above patch you provided. (Failed to return EINVAL on negative value of n to select()) Please let me know about this. I have tested on PPC32 2.6.23. -Halesh > >Paul. ------------------------------------------------------------------- This email is confidential and intended only for the use of the individual or entity named above and may contain information that is privileged. If you are not the intended recipient, you are notified that any dissemination, distribution or copying of this email is strictly prohibited. If you have received this email in error, please notify us immediately by return email or telephone and destroy the original message. - This mail is sent via Sony Asia Pacific Mail Gateway. ------------------------------------------------------------------- _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
