On Mon, Feb 23, 2026 at 03:02:32PM -0800, Kees Cook wrote: > On Mon, Feb 23, 2026 at 03:53:11PM -0700, Nathan Chancellor wrote: > > On Mon, Feb 23, 2026 at 02:33:35PM -0800, Kees Cook wrote: > > > Series looks good to me. One style question, why go the round-trip with > > > Kconfig instead of doing it all with a fallback in the Makefile: > > > > > > CC_FLAGS_DIALECT += $(call > > > cc-option,-fms-anonymous-structs,-fms-extensions) > > > > I might be misunderstanding how Kbuild works but > > arch/$(SRCARCH)/Makefile may have logic for selecting CROSS_COMPILE, > > which can impact the selection of $(CC), so I cannot use cc-option prior > > to its inclusion but I need CC_FLAGS_DIALECT to be included before > > arch/$(SRCARCH)/Makefile in the main build so that they can be used > > within it, which is only possible after Kconfig has run. This is > > probably worth more flushing out in the code or a comment since it is > > subtle. > > Will Kconfig see a different CC than Makefile? Regardless, I trust your
It shouldn't, as arch/$(SRCARCH)/Makefile is included before invoking Kconfig; if the compiler changes, Kconfig will run again before building. > judgement here! I actually rather prefer having it exposed via Kconfig. > :) > > Reviewed-by: Kees Cook <[email protected]> Thanks! Nathan
