Re: [PATCH v3 4/7] riscv: Stop calling page_address() in free_pages()

[Alexandre Ghiti]

Hi Vishal,

On 9/3/25 20:59, Vishal Moola (Oracle) wrote:

free_pages() should be used when we only have a virtual address. We
should call __free_pages() directly on our page instead.

Signed-off-by: Vishal Moola (Oracle) <vishal.mo...@gmail.com>
---
  arch/riscv/mm/init.c | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/riscv/mm/init.c b/arch/riscv/mm/init.c
index 15683ae13fa5..1056c11d3251 100644
--- a/arch/riscv/mm/init.c
+++ b/arch/riscv/mm/init.c
@@ -1624,7 +1624,7 @@ static void __meminit free_pud_table(pud_t *pud_start, 
p4d_t *p4d)
        if (PageReserved(page))
                free_reserved_page(page);
        else
-               free_pages((unsigned long)page_address(page), 0);
+               __free_pages(page, 0);
        p4d_clear(p4d);
  }

@@ -1646,7 +1646,7 @@ static void __meminit free_vmemmap_storage(struct page *page, size_t size,

                return;
        }

- free_pages((unsigned long)page_address(page), order);

+       __free_pages(page, order);
  }

static void __meminit remove_pte_mapping(pte_t *pte_base, unsigned long addr, unsigned long end,

Acked-by: Alexandre Ghiti <alexgh...@rivosinc.com>

Thanks,

Alex