David Hildenbrand <da...@redhat.com> writes: > We want to make use of "pgtable_level" for an enum in core-mm. Other > architectures seem to call "struct pgtable_level" either: > * "struct pg_level" when not exposed in a header (riscv, arm) > * "struct ptdump_pg_level" when expose in a header (arm64) > > So let's follow what arm64 does. > > Signed-off-by: David Hildenbrand <da...@redhat.com> > --- > arch/powerpc/mm/ptdump/8xx.c | 2 +- > arch/powerpc/mm/ptdump/book3s64.c | 2 +- > arch/powerpc/mm/ptdump/ptdump.h | 4 ++-- > arch/powerpc/mm/ptdump/shared.c | 2 +- > 4 files changed, 5 insertions(+), 5 deletions(-)
As mentioned in commit msg mostly a mechanical change to convert "struct pgtable_level" to "struct ptdump_pg_level" for aforementioned purpose.. The patch looks ok and compiles fine on my book3s64 and ppc32 platform. I think we should fix the subject line.. s/ptdump_pglevel/ptdump_pg_level Otherwise the changes looks good to me. So please feel free to add - Reviewed-by: Ritesh Harjani (IBM) <ritesh.l...@gmail.com> > > diff --git a/arch/powerpc/mm/ptdump/8xx.c b/arch/powerpc/mm/ptdump/8xx.c > index b5c79b11ea3c2..4ca9cf7a90c9e 100644 > --- a/arch/powerpc/mm/ptdump/8xx.c > +++ b/arch/powerpc/mm/ptdump/8xx.c > @@ -69,7 +69,7 @@ static const struct flag_info flag_array[] = { > } > }; > > -struct pgtable_level pg_level[5] = { > +struct ptdump_pg_level pg_level[5] = { > { /* pgd */ > .flag = flag_array, > .num = ARRAY_SIZE(flag_array), > diff --git a/arch/powerpc/mm/ptdump/book3s64.c > b/arch/powerpc/mm/ptdump/book3s64.c > index 5ad92d9dc5d10..6b2da9241d4c4 100644 > --- a/arch/powerpc/mm/ptdump/book3s64.c > +++ b/arch/powerpc/mm/ptdump/book3s64.c > @@ -102,7 +102,7 @@ static const struct flag_info flag_array[] = { > } > }; > > -struct pgtable_level pg_level[5] = { > +struct ptdump_pg_level pg_level[5] = { > { /* pgd */ > .flag = flag_array, > .num = ARRAY_SIZE(flag_array), > diff --git a/arch/powerpc/mm/ptdump/ptdump.h b/arch/powerpc/mm/ptdump/ptdump.h > index 154efae96ae09..4232aa4b57eae 100644 > --- a/arch/powerpc/mm/ptdump/ptdump.h > +++ b/arch/powerpc/mm/ptdump/ptdump.h > @@ -11,12 +11,12 @@ struct flag_info { > int shift; > }; > > -struct pgtable_level { > +struct ptdump_pg_level { > const struct flag_info *flag; > size_t num; > u64 mask; > }; > > -extern struct pgtable_level pg_level[5]; > +extern struct ptdump_pg_level pg_level[5]; > > void pt_dump_size(struct seq_file *m, unsigned long delta); > diff --git a/arch/powerpc/mm/ptdump/shared.c b/arch/powerpc/mm/ptdump/shared.c > index 39c30c62b7ea7..58998960eb9a4 100644 > --- a/arch/powerpc/mm/ptdump/shared.c > +++ b/arch/powerpc/mm/ptdump/shared.c > @@ -67,7 +67,7 @@ static const struct flag_info flag_array[] = { > } > }; > > -struct pgtable_level pg_level[5] = { > +struct ptdump_pg_level pg_level[5] = { > { /* pgd */ > .flag = flag_array, > .num = ARRAY_SIZE(flag_array), > -- > 2.50.1