Le 27/07/2025 à 18:24, Markus Elfring a écrit :
platform_get_resource() returns NULL in case of failure, so check its
return value and propagate the error in order to prevent NULL pointer
dereference.
How do you think about to add any tags (like “Fixes” and “Cc”) accordingly?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.16-rc7#n145
Fixes: 6305166c8771 ("bus: fsl-mc: Add ACPI support for fsl-mc")
…
+++ b/drivers/bus/fsl-mc/fsl-mc-bus.c
@@ -1105,6 +1105,10 @@ static int fsl_mc_bus_probe(struct platform_device *pdev)
* Get physical address of MC portal for the root DPRC:
*/
plat_res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
+
+ if (!plat_res)
+ return -ENODEV;
Before the blame commit, of_address_to_resource() was used and
of_address_to_resource() returns -EINVAL in case no resource is found.
Should we keep the same return instead of ENODEV ?
…
I suggest to omit a blank line before the if statement.
Regards,
Markus
