On Fri, Jun 13, 2025 at 06:01:41PM +0200, Alexander Gordeev wrote: > On Sat, Jun 07, 2025 at 01:04:51PM -0700, Eric Biggers wrote: > > From: Eric Biggers <ebigg...@google.com> > > > > Move the s390-optimized CRC code from arch/s390/lib/crc* into its new > > location in lib/crc/s390/, and wire it up in the new way. This new way > > of organizing the CRC code eliminates the need to artificially split the > > code for each CRC variant into separate arch and generic modules, > > enabling better inlining and dead code elimination. For more details, > > see "lib/crc: prepare for arch-optimized code in subdirs of lib/crc/". > > > > Signed-off-by: Eric Biggers <ebigg...@google.com> > ... > > Hi Eric, > > With this series I am getting on s390: > > alg: hash: skipping comparison tests for crc32c-s390 because crc32c-generic > is unavailable > > Thanks!
I think that's actually from "crypto/crc32c: register only one shash_alg" (https://lore.kernel.org/linux-crypto/20250601224441.778374-3-ebigg...@kernel.org/), not the patch you replied to. Those self-test warnings are expected. But I guess they are going to confuse people, so we should do something to make them go away. I think we should do what I've proposed for SHA-512: stop worrying about setting the cra_driver_name to something meaningful (which has never really worked anyway), instead just use *-lib, and update crypto/testmgr.c accordingly. I'll send out patches that do that. - Eric
