On Fri, 19 Sep 2008 10:31:34 -0700
"Victor Gallardo" <[EMAIL PROTECTED]> wrote:

>  
> Hi Josh,
> 
> See below...
> 
> >> ...
> >> @@ -83,9 +83,23 @@ config CANYONLANDS
> >>    select 460EX
> >>    select PCI
> >>    select PPC4xx_PCI_EXPRESS
> >> +  select IBM_NEW_EMAC_EMAC4
> >> +  select IBM_NEW_EMAC_RGMII
> >> +  select IBM_NEW_EMAC_ZMII
> >> +  select IBM_NEW_EMAC_TAH
> >>    help
> >>      This option enables support for the AMCC PPC460EX evaluation board.
> >> 
> >> +config ARCHES
> >> +  bool "Arches"
> >> +  depends on 44x
> >> +  default n
> >> +  select 460EX
> >> +  select IBM_NEW_EMAC_EMAC4
> >> +  select IBM_NEW_EMAC_TAH
> >> +  help
> >> +    This option enables support for the AMCC PPC460GT evaluation board.
> >
> >This seems fine.
> >
> > ...
> >
> >> +obj-$(CONFIG_ARCHES)      += canyonlands.o
> >>  obj-$(CONFIG_CANYONLANDS) += canyonlands.o
> >>  obj-$(CONFIG_XILINX_VIRTEX_5_FXT) += virtex.o
> >
> >Instead of modifying the Makefile, you should only have to add the 
> >"amcc,arches"
> > string to the >"board" array in ppc44x_simple.c.
> >
> > We switched to doing this as opposed to having a somewhat bogus 
> > "board compatible" statement with >other boards.  That is what was 
> > discussed at
> > OLS, and this is the result.
> 
> The reason for two different board types is to remove RGMII and ZMII from the 
> build. Arches does not use it.

Right, and that part is fine.

> 
> Where is ppc4xx_simple.c? I just pulled your git tree and did not find this 
> file.

You need to look in the 'next' branch.

http://git.kernel.org/?p=linux/kernel/git/jwboyer/powerpc-4xx.git;a=tree;f=arch/powerpc/platforms/44x;h=c5cae8d37f170193ed45b7b76e3cb2cbb8be927a;hb=next

josh
_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev

Reply via email to