Hi Adrian, On Sat, 7 Jun 2025 at 14:08, John Paul Adrian Glaubitz <glaub...@physik.fu-berlin.de> wrote: > On Sat, 2025-03-15 at 11:59 +0100, Arnd Bergmann wrote: > > From: Arnd Bergmann <a...@arndb.de> > > > > The ioread/iowrite functions on sh only do memory mapped I/O like the > > generic verion, and never map onto non-MMIO inb/outb variants, so they > > just add complexity. In particular, the use of asm-generic/iomap.h > > ties the declaration to the x86 implementation. > > > > Remove the custom versions and use the architecture-independent fallback > > code instead. Some of the calling conventions on sh are different here, > > so fix that by adding 'volatile' keywords where required by the generic > > implementation and change the cpg clock driver to no longer depend on > > the interesting choice of return types for ioread8/ioread16/ioread32. > > > > Signed-off-by: Arnd Bergmann <a...@arndb.de>
> Those are quite a number of changes that I would like to test on real hardware > first before merging them into the kernel. > > @Geert: Could you test it on your SH-7751 LANDISK board as well? Already done for a while, as this patch is commit 2494fce26e434071 ("sh: remove duplicate ioread/iowrite helpers") in v6.15-rc1 ;-) Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds