When compiling for pseries or powernv defconfig with "make C=1",
these warning were reported by sparse tool in powerpc/kernel/kvm.c

arch/powerpc/kernel/kvm.c:635:9: warning: switch with no cases
arch/powerpc/kernel/kvm.c:646:9: warning: switch with no cases

Currently #ifdef were added after the switch case which are specific
for BOOKE and PPC_BOOK3S_32. These are not enabled in pseries/powernv
defconfig. Fix it by moving the #ifdef before switch(){}

Signed-off-by: Madhavan Srinivasan <ma...@linux.ibm.com>
---
 arch/powerpc/kernel/kvm.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/arch/powerpc/kernel/kvm.c b/arch/powerpc/kernel/kvm.c
index 5b3c093611ba..7209d00a9c25 100644
--- a/arch/powerpc/kernel/kvm.c
+++ b/arch/powerpc/kernel/kvm.c
@@ -632,19 +632,19 @@ static void __init kvm_check_ins(u32 *inst, u32 features)
 #endif
        }
 
-       switch (inst_no_rt & ~KVM_MASK_RB) {
 #ifdef CONFIG_PPC_BOOK3S_32
+       switch (inst_no_rt & ~KVM_MASK_RB) {
        case KVM_INST_MTSRIN:
                if (features & KVM_MAGIC_FEAT_SR) {
                        u32 inst_rb = _inst & KVM_MASK_RB;
                        kvm_patch_ins_mtsrin(inst, inst_rt, inst_rb);
                }
                break;
-#endif
        }
+#endif
 
-       switch (_inst) {
 #ifdef CONFIG_BOOKE
+       switch (_inst) {
        case KVM_INST_WRTEEI_0:
                kvm_patch_ins_wrteei_0(inst);
                break;
@@ -652,8 +652,8 @@ static void __init kvm_check_ins(u32 *inst, u32 features)
        case KVM_INST_WRTEEI_1:
                kvm_patch_ins_wrtee(inst, 0, 1);
                break;
-#endif
        }
+#endif
 }
 
 extern u32 kvm_template_start[];
-- 
2.49.0


Reply via email to