On Sat, Mar 22, 2025, at 14:23, Andy Shevchenko wrote: > Thu, Mar 20, 2025 at 01:23:25AM +0100, Andi Shyti kirjoitti: >> Hi Sven, >> >> On Sat, Feb 22, 2025 at 01:38:33PM +0000, Sven Peter via B4 Relay wrote: >> > From: Sven Peter <s...@svenpeter.dev> >> > >> > Add the missing register bits to the defines and also switch >> > those to use the BIT macro which is much more readable than >> > using hardcoded masks >> > >> > Co-developed-by: Hector Martin <mar...@marcan.st> >> > Signed-off-by: Hector Martin <mar...@marcan.st> >> > Signed-off-by: Sven Peter <s...@svenpeter.dev> >> >> Just this patch merged to i2c/i2c-host. > > This needs an update as well. The proper header for BIT() et al. is bits.h. > bitfield.h is for FIELD_*() et al.
Ugh, good catch. Since this commit is already on the way upstream I'll send a fix (and another one to sort the headers alphabetically while I'm at it anyway). Thanks, Sven
