út 25. 3. 2025 v 15:59 odesílatel Tomas Glozar <tglo...@redhat.com> napsal: > Shouldn't the selftests always test the in-tree bpftool instead of the > system one? Let's say there is a stray BPFTOOL environmental variable. > In that case, the tests will give incorrect, possibly false negative > results, if the user is expecting selftests to test what is in the > kernel tree. If it is intended to also be able to test with another > version of bpftool, we can work around the problem by removing the > BPFTOOL definition from tools/scripts/Makefile.include and exporting > it from the rtla Makefiles instead, to make sure the feature tests see > it. The problem with that is, obviously, that future users of the > bpftool feature check would have to do the same, or they would always > fail, unless the user sets BPFTOOL as an environment variable > themselves.
Or the selftests and other users could use another variable, like BPFTOOL_TEST or BPFTOOL_INTERNAL. Not sure what you BPF folks think about that. I believe assuming BPFTOOL refers to the system bpftool (just like it does for all the other tools) is quite reasonable. Tomas
