Hi all, now that the printf and scanf series have been taken via kees' tree[0] and sent in for v6.15-rc1[1], I wonder if we'd like to revisit this discussion.
As I understand it, the primary objections to moving bitmap to KUnit were: - Unclear benefits. - Source churn. - Extra dependencies for benchmarks. Hopefully David's enumeration of the benefits of KUnit was compelling. Regarding source churn: it is inevitable, but I did pay attention to this and minimized the diff where possible. The last point is trickiest, because KUnit doesn't have first-class benchmark support, but nor is there a blessed benchmark facility in the kernel generally. I'd prefer not to tie this series to distros enabling KUNIT_CONFIG by default, which will take $time. I think the most sensible thing we can do - if we accept that KUnit has benefits to offer - is to split test_bitmap.c into benchmark_bitmap.c and bitmap_kunit.c. Please let me know your thoughts. Tamir [0] https://web.git.kernel.org/pub/scm/linux/kernel/git/kees/linux.git/log/?h=move-lib-kunit-v6.15-rc1 [1] https://lore.kernel.org/all/202503170842.FFEE75351@keescook/
