On Tue, 4 Mar 2025 15:21:49 +0800 Wei Fang wrote: > +config NXP_NETC_LIB > + tristate "NETC Library"
Remove the string after "tristate", the user should not be prompted to make a choice for this, since the consumers "select" this config directly. > + help > + This module provides common functionalities for both ENETC and NETC > + Switch, such as NETC Table Management Protocol (NTMP) 2.0, common tc > + flower and debugfs interfaces and so on. > + > + If compiled as module (M), the module name is nxp-netc-lib. Not sure if the help makes sense for an invisible symbol either. > config FSL_ENETC > tristate "ENETC PF driver" > depends on PCI_MSI > @@ -40,6 +50,7 @@ config NXP_ENETC4 > select FSL_ENETC_CORE > select FSL_ENETC_MDIO > select NXP_ENETC_PF_COMMON > + select NXP_NETC_LIB > select PHYLINK > select DIMLIB > help > +#pragma pack(1) please don't blindly pack all structs, only if they are misaligned or will otherwise have holes. > +#if IS_ENABLED(CONFIG_NXP_NETC_LIB) why the ifdef, all callers select the config option
