On 2/27/25 01:23, Catalin Marinas wrote: > On Wed, Feb 26, 2025 at 05:54:04PM +0530, Anshuman Khandual wrote: >> diff --git a/arch/arm64/include/asm/ptdump.h >> b/arch/arm64/include/asm/ptdump.h >> index 6cf4aae05219..b2931d1ae0fb 100644 >> --- a/arch/arm64/include/asm/ptdump.h >> +++ b/arch/arm64/include/asm/ptdump.h >> @@ -7,7 +7,7 @@ >> >> #include <linux/ptdump.h> >> >> -#ifdef CONFIG_PTDUMP_CORE >> +#ifdef CONFIG_PTDUMP > > Do we need this #ifdef at all? I haven't tried but usually, if the > feature is not enabled, the header file on its own should be harmless.
With or without the #ifdef CONFIG_PTDUMP in place here, this does not cause any build warnings even without CONFIG_PTDUMP enabled. But dropping #ifdef while renaming the config option itself, might have caused unrelated code churn. So probably if required we could drop this later on. > > For arm64: > > Acked-by: Catalin Marinas <catalin.mari...@arm.com>
