On Tue, Feb 18, 2025 at 03:49:54PM +0530, Anshuman Khandual wrote: > From: Ryan Roberts <ryan.robe...@arm.com> > > ioremap_prot() currently accepts pgprot_val parameter as an unsigned long, > thus implicitly assuming that pgprot_val and pgprot_t could never be bigger > than unsigned long. But this assumption soon will not be true on arm64 when > using D128 pgtables. In 128 bit page table configuration, unsigned long is > 64 bit, but pgprot_t is 128 bit. > > Passing platform abstracted pgprot_t argument is better as compared to size > based data types. Let's change the parameter to directly pass pgprot_t like > another similar helper generic_ioremap_prot(). > > Without this change in place, D128 configuration does not work on arm64 as > the top 64 bits gets silently stripped when passing the protection value to > this function. > > Cc: Andrew Morton <a...@linux-foundation.org> > Cc: linux-arm-ker...@lists.infradead.org > Cc: linux-snps-...@lists.infradead.org > Cc: linux-ri...@lists.infradead.org > Cc: linuxppc-dev@lists.ozlabs.org > Cc: linux-par...@vger.kernel.org > Cc: linux-c...@vger.kernel.org > Cc: linux-m...@vger.kernel.org > Cc: linux-s...@vger.kernel.org > Cc: linux-a...@vger.kernel.org > Cc: loonga...@lists.linux.dev > Cc: linux...@vger.kernel.org > Cc: linux...@kvack.org > Cc: linux-ker...@vger.kernel.org > Signed-off-by: Ryan Roberts <ryan.robe...@arm.com> > Co-developed-by: Anshuman Khandual <anshuman.khand...@arm.com> > Signed-off-by: Anshuman Khandual <anshuman.khand...@arm.com>
For arm64: Acked-by: Catalin Marinas <catalin.mari...@arm.com>
