Hi Drew, On Tue, Jan 21, 2025 at 03:48:55PM +0100, Andrew Jones wrote: > On Mon, Jan 20, 2025 at 04:43:01PM +0000, Alexandru Elisei wrote: <snip> > > --- > > arm/efi/run | 8 ++++++++ > > arm/run | 9 +++++++++ > > run_tests.sh | 8 ++++++++ > > scripts/mkstandalone.sh | 8 ++++++++ > > 4 files changed, 33 insertions(+) <snip> > > +case "$TARGET" in > > +qemu) > > + ;; > > +*) > > + echo "'$TARGET' not supported for standlone tests" > > + exit 2 > > +esac > > I think we could put the check in a function in scripts/arch-run.bash and > just use the same error message for all cases.
Coming back to the series. arm/efi/run and arm/run source scripts/arch-run.bash; run_tests.sh and scripts/mkstandalone.sh don't source scripts/arch-run.bash. There doesn't seem to be a common file that is sourced by all of them. How about creating a new file in scripts (vmm.bash?) with only this function? Thanks, Alex > > Thanks, > drew > > > > > -- > > kvm-riscv mailing list > > kvm-ri...@lists.infradead.org > > http://lists.infradead.org/mailman/listinfo/kvm-riscv
