Hi Alistair,

kernel test robot noticed the following build warnings:

[auto build test WARNING on e25c8d66f6786300b680866c0e0139981273feba]

url:    
https://github.com/intel-lab-lkp/linux/commits/Alistair-Popple/fuse-Fix-dax-truncate-punch_hole-fault-path/20250107-114726
base:   e25c8d66f6786300b680866c0e0139981273feba
patch link:    
https://lore.kernel.org/r/5729b98a4f8edfec80edffddc36cac6dbaa8f4b9.1736221254.git-series.apopple%40nvidia.com
patch subject: [PATCH v5 15/25] huge_memory: Add vmf_insert_folio_pud()
config: i386-buildonly-randconfig-004-20250108 
(https://download.01.org/0day-ci/archive/20250108/202501081149.vdlf8cwh-...@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): 
(https://download.01.org/0day-ci/archive/20250108/202501081149.vdlf8cwh-...@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <l...@intel.com>
| Closes: 
https://lore.kernel.org/oe-kbuild-all/202501081149.vdlf8cwh-...@intel.com/

All warnings (new ones prefixed by >>):

>> mm/huge_memory.c:1561: warning: Function parameter or struct member 'folio' 
>> not described in 'vmf_insert_folio_pud'
>> mm/huge_memory.c:1561: warning: Excess function parameter 'pfn' description 
>> in 'vmf_insert_folio_pud'


vim +1561 mm/huge_memory.c

  1551  
  1552  /**
  1553   * vmf_insert_folio_pud - insert a pud size folio mapped by a pud entry
  1554   * @vmf: Structure describing the fault
  1555   * @pfn: pfn of the page to insert
  1556   * @write: whether it's a write fault
  1557   *
  1558   * Return: vm_fault_t value.
  1559   */
  1560  vm_fault_t vmf_insert_folio_pud(struct vm_fault *vmf, struct folio 
*folio, bool write)
> 1561  {
  1562          struct vm_area_struct *vma = vmf->vma;
  1563          unsigned long addr = vmf->address & PUD_MASK;
  1564          pud_t *pud = vmf->pud;
  1565          struct mm_struct *mm = vma->vm_mm;
  1566          spinlock_t *ptl;
  1567  
  1568          if (addr < vma->vm_start || addr >= vma->vm_end)
  1569                  return VM_FAULT_SIGBUS;
  1570  
  1571          if (WARN_ON_ONCE(folio_order(folio) != PUD_ORDER))
  1572                  return VM_FAULT_SIGBUS;
  1573  
  1574          ptl = pud_lock(mm, pud);
  1575          if (pud_none(*vmf->pud)) {
  1576                  folio_get(folio);
  1577                  folio_add_file_rmap_pud(folio, &folio->page, vma);
  1578                  add_mm_counter(mm, mm_counter_file(folio), 
HPAGE_PUD_NR);
  1579          }
  1580          insert_pfn_pud(vma, addr, vmf->pud, 
pfn_to_pfn_t(folio_pfn(folio)), write);
  1581          spin_unlock(ptl);
  1582  
  1583          return VM_FAULT_NOPAGE;
  1584  }
  1585  EXPORT_SYMBOL_GPL(vmf_insert_folio_pud);
  1586  #endif /* CONFIG_HAVE_ARCH_TRANSPARENT_HUGEPAGE_PUD */
  1587  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

Reply via email to