On Mon, 2024-12-23 at 09:12 +0200, Mike Rapoport wrote: > On Sun, Dec 22, 2024 at 07:15:37PM +0800, Guo Weikang wrote: > > Before SLUB initialization, various subsystems used memblock_alloc to > > allocate memory. In most cases, when memory allocation fails, an immediate > > panic is required. To simplify this behavior and reduce repetitive checks, > > introduce `memblock_alloc_or_panic`. This function ensures that memory > > allocation failures result in a panic automatically, improving code > > readability and consistency across subsystems that require this behavior. > > > > Changelog: > > ---------- > > v1: initial version > > v2: add __memblock_alloc_or_panic support panic output caller > > v3: panic output phys_addr_t use printk's %pap > > v4: make __memblock_alloc_or_panic out-of-line, move to memblock.c > > v6: Fix CI compile error > > Links to CI: > > https://lore.kernel.org/oe-kbuild-all/202412221000.r1nzxjuo-...@intel.com/ > > v6: Fix CI compile warinigs > > Links to CI: > > https://lore.kernel.org/oe-kbuild-all/202412221259.jugnaucq-...@intel.com/ > > v7: add chagelog and adjust function declaration alignment format > > ---------- > > > > Signed-off-by: Guo Weikang <guoweikang.ker...@gmail.com> > > Reviewed-by: Andrew Morton <a...@linux-foundation.org> > > Reviewed-by: Geert Uytterhoeven <ge...@linux-m68k.org> > > Reviewed-by: Mike Rapoport (Microsoft) <r...@kernel.org> > > Acked-by: Xi Ruoyao <xry...@xry111.site> > > If people commented on your patch it does not mean you should add > Reviewed-by or Acked-by tags for them. Wait for explicit tags from the > reviewers.
And: - Acked-by: indicates an agreement by another developer (often a maintainer of the relevant code) that the patch is appropriate for inclusion into the kernel. I'm not a maintainer so I even don't have the right to use Acked-by :). -- Xi Ruoyao <xry...@xry111.site> School of Aerospace Science and Technology, Xidian University
