Thorsten Blum <thorsten.b...@linux.dev> writes: > Remove hard-coded strings by using the str_on_off() helper function. > > Signed-off-by: Thorsten Blum <thorsten.b...@linux.dev> > --- > arch/powerpc/kernel/setup-common.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/powerpc/kernel/setup-common.c > b/arch/powerpc/kernel/setup-common.c > index 6fa179448c33..f7d7a93f07fc 100644 > --- a/arch/powerpc/kernel/setup-common.c > +++ b/arch/powerpc/kernel/setup-common.c > @@ -834,8 +834,8 @@ static int __init check_cache_coherency(void) > if (devtree_coherency != KERNEL_COHERENCY) { > printk(KERN_ERR > "kernel coherency:%s != device tree_coherency:%s\n", > - KERNEL_COHERENCY ? "on" : "off", > - devtree_coherency ? "on" : "off"); > + str_on_off(KERNEL_COHERENCY), > + str_on_off(devtree_coherency)); > BUG(); > }
Looks good to me. Please feel free to add - Reviewed-by: Ritesh Harjani (IBM) <ritesh.l...@gmail.com> -ritesh