Benjamin Herrenschmidt wrote: >>> 1. total_memory should be phys_addr_t not unsigned long >>> 2. is_power_of_2() works with u32 so I just inlined (size & (size-1)) != 0 >>> instead. >>> Also this patch fixes default initialization: res->end should be 0x7fffffff >>> not 0x80000000. >>> >>> Signed-off-by: Ilya Yanok <[EMAIL PROTECTED]> >>> >> Ben, any comments here? Looks right to me. >> > > Just one minor comment... The patch should do what I failed to do > before, which is to move total_memory declaration to a header :-) >
Hm... looks like we already have this declaration in arch/powerpc/mm/mmu_decl.h... I'll send modified patch soon. Regards, Ilya. _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
