Hi Geert,
On 11/6/24 22:26, Geert Uytterhoeven wrote:
> ps3_setup_uhc_device() is only called from ps3_setup_ehci_device() and
> ps3_setup_ohci_device(), which are both marked __init. Hence replace
> the former's __ref marker by __init.
>
> Note that before commit bd721ea73e1f9655 ("treewide: replace obsolete
> _refok by __ref"), the function was marked __init_refok, which probably
> should have been __init in the first place.
>
> Signed-off-by: Geert Uytterhoeven <geert+rene...@glider.be>
> ---
> arch/powerpc/platforms/ps3/device-init.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/powerpc/platforms/ps3/device-init.c
> b/arch/powerpc/platforms/ps3/device-init.c
> index b18e1c92e554ce87..61722133eb2d3f99 100644
> --- a/arch/powerpc/platforms/ps3/device-init.c
> +++ b/arch/powerpc/platforms/ps3/device-init.c
> @@ -178,7 +178,7 @@ static int __init ps3_setup_gelic_device(
> return result;
> }
>
> -static int __ref ps3_setup_uhc_device(
> +static int __init ps3_setup_uhc_device(
> const struct ps3_repository_device *repo, enum ps3_match_id match_id,
> enum ps3_interrupt_type interrupt_type, enum ps3_reg_type reg_type)
> {
I tested this on PS3 and it seems to work OK.
Acked-by: Geoff Levand <ge...@infradead.org>
