[PATCH] macintosh: Use common error handling code in via_pmu_led_init()

[Markus Elfring]

From: Markus Elfring <elfr...@users.sourceforge.net>
Date: Thu, 3 Oct 2024 21:06:42 +0200

Add a jump target so that a bit of exception handling can be better reused
at the end of this function implementation.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfr...@users.sourceforge.net>
---
 drivers/macintosh/via-pmu-led.c | 19 ++++++++++---------
 1 file changed, 10 insertions(+), 9 deletions(-)

diff --git a/drivers/macintosh/via-pmu-led.c b/drivers/macintosh/via-pmu-led.c
index a4fb16d7db3c..fc1af74b6596 100644
--- a/drivers/macintosh/via-pmu-led.c
+++ b/drivers/macintosh/via-pmu-led.c
@@ -92,18 +92,15 @@ static int __init via_pmu_led_init(void)
        if (dt == NULL)
                return -ENODEV;
        model = of_get_property(dt, "model", NULL);
-       if (model == NULL) {
-               of_node_put(dt);
-               return -ENODEV;
-       }
+       if (!model)
+               goto put_node;
+
        if (strncmp(model, "PowerBook", strlen("PowerBook")) != 0 &&
            strncmp(model, "iBook", strlen("iBook")) != 0 &&
            strcmp(model, "PowerMac7,2") != 0 &&
-           strcmp(model, "PowerMac7,3") != 0) {
-               of_node_put(dt);
-               /* ignore */
-               return -ENODEV;
-       }
+           strcmp(model, "PowerMac7,3") != 0)
+               goto put_node;
+
        of_node_put(dt);

        spin_lock_init(&pmu_blink_lock);
@@ -112,6 +109,10 @@ static int __init via_pmu_led_init(void)
        pmu_blink_req.done = pmu_req_done;

        return led_classdev_register(NULL, &pmu_led);
+
+put_node:
+       of_node_put(dt);
+       return -ENODEV;
 }

 late_initcall(via_pmu_led_init);
--
2.46.1