Le 12/08/2024 à 09:25, Lu Baolu a écrit :
[Vous ne recevez pas souvent de courriers de baolu...@linux.intel.com. 
Découvrez pourquoi ceci est important à 
https://aka.ms/LearnAboutSenderIdentification ]

An iommu domain is allocated in portal_set_cpu() and is attached to
pcfg->dev in the same function.

Use iommu_paging_domain_alloc() to make it explicit.

Signed-off-by: Lu Baolu <baolu...@linux.intel.com>
Reviewed-by: Jason Gunthorpe <j...@nvidia.com>
Link: https://lore.kernel.org/r/20240610085555.88197-14-baolu...@linux.intel.com
---
  drivers/soc/fsl/qbman/qman_portal.c | 5 +++--
  1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/soc/fsl/qbman/qman_portal.c 
b/drivers/soc/fsl/qbman/qman_portal.c
index e23b60618c1a..456ef5d5c199 100644
--- a/drivers/soc/fsl/qbman/qman_portal.c
+++ b/drivers/soc/fsl/qbman/qman_portal.c
@@ -48,9 +48,10 @@ static void portal_set_cpu(struct qm_portal_config *pcfg, 
int cpu)
         struct device *dev = pcfg->dev;
         int ret;

-       pcfg->iommu_domain = iommu_domain_alloc(&platform_bus_type);
-       if (!pcfg->iommu_domain) {
+       pcfg->iommu_domain = iommu_paging_domain_alloc(dev);
+       if (IS_ERR(pcfg->iommu_domain)) {
                 dev_err(dev, "%s(): iommu_domain_alloc() failed", __func__);
+               pcfg->iommu_domain = NULL;
                 goto no_iommu;
         }
         ret = fsl_pamu_configure_l1_stash(pcfg->iommu_domain, cpu);
--
2.34.1


Applied for 6.12

Thanks
Christophe

Reply via email to