Le 22/08/2024 à 17:25, cuigaosheng a écrit :
[Vous ne recevez pas souvent de courriers de cuigaoshe...@huawei.com. Découvrez pourquoi ceci est important à https://aka.ms/LearnAboutSenderIdentification ]

On 2024/8/22 22:16, LEROY Christophe wrote:

Le 22/08/2024 à 15:06, Gaosheng Cui a écrit :
[Vous ne recevez pas souvent de courriers de cuigaoshe...@huawei.com. Découvrez pourquoi ceci est important à https://aka.ms/LearnAboutSenderIdentification ]

The _get_SP() have been removed since
commit 917f0af9e5a9 ("powerpc: Remove arch/ppc and include/asm-ppc"),
and now it is useless, so remove it.
Not sure that commit is relevant since it relates to arch/ppc/ not
arch/powerpc/

For arch/powerpc/ I think it is commit f4db196717c6 ("[POWERPC] Remove
_get_SP")

In commit 1da177e4c3f4, linux implemented the _get_SP function in misc.S
and declared and use it in arch/ppc/kernel/process.c, the declaration
of _get_SP in arch/powerpc/kernel/process.c was introduced in commit
14cf11af6cf608, but at this time arch/powerpc/kernel/misc_32.S has not
been introduced yet,so I think the declaration belongs to _get_SP in the
misc.S,it have been removed since commit 917f0af9e5a9.

In addition, commit f4db196717c6 is v2.6.22 but 917f0af9e5a9 is v2.6.27, so I think
it is commit 917f0af9e5a9.

Nevermind

Reviewed-by: Christophe Leroy <christophe.le...@csgroup.eu>


anything others?thanks very much.

Signed-off-by: Gaosheng Cui <cuigaoshe...@huawei.com>
---
   arch/powerpc/kernel/process.c | 2 --
   1 file changed, 2 deletions(-)

diff --git a/arch/powerpc/kernel/process.c b/arch/powerpc/kernel/process.c
index 3b506d4c55f3..e7b70c2cc001 100644
--- a/arch/powerpc/kernel/process.c
+++ b/arch/powerpc/kernel/process.c
@@ -72,8 +72,6 @@
   #define TM_DEBUG(x...) do { } while(0)
   #endif

-extern unsigned long _get_SP(void);
-
   #ifdef CONFIG_PPC_TRANSACTIONAL_MEM
   /*
    * Are we running in "Suspend disabled" mode? If so we have to block any
--
2.25.1


Reply via email to