Ritesh Harjani (IBM) <ritesh.l...@gmail.com> writes:
> This is a generic review and I haven't looked into the PAPR spec for
> htmdump hcall and it's interface.
>
> Madhavan Srinivasan <ma...@linux.ibm.com> writes:
...
>> +
>> + debugfs_create_u32("nodeindex", 0600,
>> + htmdump_debugfs_dir, &nodeindex);
>> + debugfs_create_u32("nodalchipindex", 0600,
>> + htmdump_debugfs_dir, &nodalchipindex);
>> + debugfs_create_u32("coreindexonchip", 0600,
>> + htmdump_debugfs_dir, &coreindexonchip);
>> + debugfs_create_u32("htmtype", 0600,
>> + htmdump_debugfs_dir, &htmtype);
>
> minor nit: For all of the above. S_IRUSR | S_IWUSR instead of 0600.
>
>> + debugfs_create_file("trace", 0400, htmdump_debugfs_dir, ent,
>> &htmdump_fops);
>
> maybe S_IRUSR instead of 0400.
Actually we prefer the octal values, see:
https://git.kernel.org/torvalds/c/57ad583f2086d55ada284c54bfc440123cf73964
cheers
