On Sun, Oct 08, 2023 at 09:28:00AM +1100, Michael Ellerman wrote: > Joel Granados <j.grana...@samsung.com> writes: > > On Mon, Oct 02, 2023 at 12:27:18PM +0000, Christophe Leroy wrote: > >> Le 02/10/2023 à 10:55, Joel Granados via B4 Relay a écrit : > >> > From: Joel Granados <j.grana...@samsung.com> > >> > > > <--- snip ---> > >> > - The "yesall" config saves 2432 bytes [4] > >> > - The "tiny" config saves 64 bytes [5] > >> > * memory usage: > >> > In this case there were no bytes saved because I do not have any > >> > of the drivers in the patch. To measure it comment the printk in > >> > `new_dir` and uncomment the if conditional in `new_links` [3]. > >> > > >> > --- > >> > Changes in v2: > >> > - Left the dangling comma in the ctl_table arrays. > >> > - Link to v1: > >> > https://lore.kernel.org/r/20230928-jag-sysctl_remove_empty_elem_drivers-v1-0-e59120fca...@samsung.com > >> > > >> > Comments/feedback greatly appreciated > >> > >> Same problem on powerpc CI tests, all boot target failed, most of them > >> with similar OOPS, see > >> https://protect2.fireeye.com/v1/url?k=9496ce12-f51ddb24-9497455d-000babff9b5d-d6b001302bd0fd0d&q=1&e=044c4c09-2b44-4ded-a682-a5afe9b8beec&u=https%3A%2F%2Fpatchwork.ozlabs.org%2Fproject%2Flinuxppc-dev%2Fpatch%2F20231002-jag-sysctl_remove_empty_elem_drivers-v2-15-02dd0d46f71e%40samsung.com%2F > > I found the culprit!. Here you are rebasing on top of v6.5.0-rc6 "INFO: > > Looking for kernel version: 6.5.0-rc6-gbf2ac4d7d596". The error makes > > sense becuase in that version we have not introduced the stopping > > criteria based on the ctl_table array size, so the loop continues > > looking for an empty sentinel past valid memory (and does not find it). > > The ctl_table check catches it but then fails to do a proper error > > because we have already tried to access invalid memory. The solution > > here is to make sure to rebase in on top of the latest rc in v6.6. > > Thanks for tracking it down. > > This is my fault, previously Russell would update the branch that the CI > uses as its base. Now that he has left I need to do that myself, but had > forgotten. > > Sorry for the noise. no worries. It was very helpfull to have two runs to compare with. That was actually the thing that helped me find the issue.
Best > > cheers -- Joel Granados
signature.asc
Description: PGP signature
