On Wed, Sep 13, 2023, 7:40 AM Athira Rajeev <atraj...@linux.vnet.ibm.com> wrote:
> > > > On 08-Sep-2023, at 7:48 PM, Athira Rajeev <atraj...@linux.vnet.ibm.com> > wrote: > > > > > > > >> On 08-Sep-2023, at 11:04 AM, Sachin Sant <sach...@linux.ibm.com> wrote: > >> > >> > >> > >>> On 07-Sep-2023, at 10:29 PM, Athira Rajeev < > atraj...@linux.vnet.ibm.com> wrote: > >>> > >>> Testcase "Parsing of all PMU events from sysfs" parse events for > >>> all PMUs, and not just cpu. In case of powerpc, the PowerVM > >>> environment supports events from hv_24x7 and hv_gpci PMU which > >>> is of example format like below: > >>> > >>> - hv_24x7/CPM_ADJUNCT_INST,domain=?,core=?/ > >>> - hv_gpci/event,partition_id=?/ > >>> > >>> The value for "?" needs to be filled in depending on system > >>> configuration. It is better to skip these parametrized events > >>> in this test as it is done in: > >>> 'commit b50d691e50e6 ("perf test: Fix "all PMU test" to skip > >>> parametrized events")' which handled a simialr instance with > >>> "all PMU test". > >>> > >>> Fix parse-events test to skip parametrized events since > >>> it needs proper setup of the parameters. > >>> > >>> Signed-off-by: Athira Rajeev <atraj...@linux.vnet.ibm.com> > >>> --- > >>> Changelog: > >>> v1 -> v2: > >>> Addressed review comments from Ian. Updated size of > >>> pmu event name variable and changed bool name which is > >>> used to skip the test. > >>> > >> > >> The patch fixes the reported issue. > >> > >> 6.2: Parsing of all PMU events from sysfs : Ok > >> 6.3: Parsing of given PMU events from sysfs : Ok > >> > >> Tested-by: Sachin Sant <sach...@linux.ibm.com> > >> > >> - Sachin > > > > Hi Sachin, Ian > > > > Thanks for testing the patch > > Hi Arnaldo > > Can you please check and pull this if it looks good to go . > Namhyung, can you please take a look? I'll be back home next week, now at Kernel Recipes in Paris. - Arnaldo > > Thanks > Athira > > > > Athira > > > > > >