On Fri, Jul 25, 2008 at 1:02 PM, Jon Smirl <[EMAIL PROTECTED]> wrote: > On 7/25/08, Grant Likely <[EMAIL PROTECTED]> wrote: >> On Fri, Jul 25, 2008 at 11:40 AM, Jon Smirl <[EMAIL PROTECTED]> wrote: >> > On 7/25/08, Grant Likely <[EMAIL PROTECTED]> wrote: >> >> + * First method is to lookup the compatible value in of_modalias_table. >> >> + * Second is to look for a "linux,<modalias>" entry in the compatible >> list >> >> + * and used that for modalias. Third is to strip off the manufacturer >> >> + * prefix from the first compatible entry and use the remainder as >> modalias >> > >> > I also think this is a problem. Embedding the name of Linux device >> > drivers into device firmware makes it almost impossible to rename the >> > device driver. Again, what is a case where generic part numbers can't >> > be listed in the alias section of the linux device driver? >> > >> > Even eeprom was just fixed to take generic part numbers (at24). >> >> Again, I agree, but this change is very much a stop gap measure to get >> things working in a sane way without having to create bad device tree >> bindings (device tree bindings are hard to change, code is not). I've >> been considering posting a patch to remove this clause from the >> functions, but that needs to be reviewed separately from this change. > > Isn't putting "compatible="linux,modalias"" into your device tree a > really bad idea?
Yes, it is, but I still need to preserve existing behavior in this patch. That change needs to be reviewed separately. I'll submit another patch to deal with this. g. -- Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd. _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
