On Wed, Jul 23, 2008 at 10:36:42AM +0200, [EMAIL PROTECTED] wrote:
Hi Christian,
A few comments inlined ...
> diff --git a/include/asm-powerpc/kvm_para.h b/include/asm-powerpc/kvm_para.h
> --- a/include/asm-powerpc/kvm_para.h
> +++ b/include/asm-powerpc/kvm_para.h
> @@ -14,7 +14,9 @@
> *
> * Copyright IBM Corp. 2008
> *
> - * Authors: Hollis Blanchard <[EMAIL PROTECTED]>
> + * Authors:
> + * Hollis Blanchard <[EMAIL PROTECTED]>
> + * Christian Ehrhardt <[EMAIL PROTECTED]>
> */
>
> #ifndef __POWERPC_KVM_PARA_H__
> @@ -22,15 +24,44 @@
>
> #ifdef __KERNEL__
>
> +#include <linux/of.h>
> +
> +static struct kvmppc_para_features {
> + char *dtcell;
> + int feature;
> +} para_features[] = {
> +};
> +
> static inline int kvm_para_available(void)
> {
> - return 0;
> + struct device_node *dn;
> +
> + dn = of_find_node_by_path("/hypervisor");
You need an of_node_put(dn);
> +
> + return !!dn;
> }
>
> static inline unsigned int kvm_arch_para_features(void)
> {
> - return 0;
> + struct device_node *dn;
> + const int *dtval;
> + unsigned int features = 0;
> + int i;
> +
> + dn = of_find_node_by_path("/hypervisor");
> + if (!dn)
> + return 0;
> +
> + for (i = 0; i < ARRAY_SIZE(para_features)-1; i++) {
Why -1? Isn't ARRAY_SIZE(para_features) adequate?
> + dtval = of_get_property(dn, para_features[i].dtcell, NULL);
> + if (dtval && *dtval == 1)
> + features |= (1 << para_features[i].feature);
> + }
> +
You need an of_node_put(dn);
> + return features;
> }
Yours Tony
linux.conf.au http://www.marchsouth.org/
Jan 19 - 24 2009 The Australian Linux Technical Conference!
_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev
