On Tue, May 23, 2023 at 1:20 PM Kees Cook <keesc...@chromium.org> wrote: > > On Tue, May 23, 2023 at 02:14:25AM +0000, Azeem Shaikh wrote: > > strlcpy() reads the entire source buffer first. > > This read may exceed the destination size limit. > > This is both inefficient and can lead to linear read > > overflows if a source string is not NUL-terminated [1]. > > In an effort to remove strlcpy() completely [2], replace > > strlcpy() here with strscpy(). > > No return values were used, so direct replacement is safe. > > > > [1] https://www.kernel.org/doc/html/latest/process/deprecated.html#strlcpy > > [2] https://github.com/KSPP/linux/issues/89 > > > > Signed-off-by: Azeem Shaikh <azeemshaik...@gmail.com> > > Reviewed-by: Kees Cook <keesc...@chromium.org> >
Friendly ping on this.
