Robert Jennings writes: > From: Brian King <[EMAIL PROTECTED]> > > Adds a collaborative memory manager, which acts as a simple balloon driver > for System p machines that support cooperative memory overcommitment > (CMO).
> +config CMM > + tristate "Collaborative memory management" > + depends on PPC_PSERIES So CMM doesn't depend on LPARCFG, yet h_get_mpp is only defined if LPARCFG=y, which makes this blow up if CMM=y and LPARCFG=n: > +static void cmm_get_mpp(void) > +{ > + int rc; > + struct hvcall_mpp_data mpp_data; > + unsigned long active_pages_target; > + signed long page_loan_request; > + > + rc = h_get_mpp(&mpp_data); Similarly, the call to h_get_mpp in vio_cmo_bus_init fails to link if PPC_PSERIES=y and LPARCFG=n, which is a possible configuration. Please think about and fix up the config dependencies. Paul. _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev