From: Immad Mir <mirimma...@gmail.com>

The debugfs_create_dir returns ERR_PTR incase of an error and the
correct way of checking it by using the IS_ERR inline function, and
not the simple null comparision. This patch fixes this.

Suggested-By: Ivan Orlov <ivan.orlov0...@gmail.com>
Signed-off-by: Immad Mir <mirimma...@gmail.com>
---
 arch/powerpc/platforms/powernv/opal-xscom.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/powerpc/platforms/powernv/opal-xscom.c 
b/arch/powerpc/platforms/powernv/opal-xscom.c
index 6b4eed2ef..262cd6fac 100644
--- a/arch/powerpc/platforms/powernv/opal-xscom.c
+++ b/arch/powerpc/platforms/powernv/opal-xscom.c
@@ -168,7 +168,7 @@ static int scom_debug_init_one(struct dentry *root, struct 
device_node *dn,
        ent->path.size = strlen((char *)ent->path.data);

        dir = debugfs_create_dir(ent->name, root);
-       if (!dir) {
+       if (IS_ERR(dir)) {
                kfree(ent->path.data);
                kfree(ent);
                return -1;
@@ -190,7 +190,7 @@ static int scom_debug_init(void)
                return 0;

        root = debugfs_create_dir("scom", arch_debugfs_dir);
-       if (!root)
+       if (IS_ERR(root))
                return -1;

        rc = 0;
--
2.40.0

Reply via email to