On Thu Mar 16, 2023 at 3:10 PM AEST, Kautuk Consul wrote: > kvmppc_hv_entry isn't called from anywhere other than > book3s_hv_rmhandlers.S itself. Removing .global scope for > this function and annotating it with SYM_INNER_LABEL. > > Signed-off-by: Kautuk Consul <kcon...@linux.vnet.ibm.com> > --- > arch/powerpc/kvm/book3s_hv_rmhandlers.S | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/arch/powerpc/kvm/book3s_hv_rmhandlers.S > b/arch/powerpc/kvm/book3s_hv_rmhandlers.S > index acf80915f406..b81ba4ee0521 100644 > --- a/arch/powerpc/kvm/book3s_hv_rmhandlers.S > +++ b/arch/powerpc/kvm/book3s_hv_rmhandlers.S > @@ -502,8 +502,7 @@ END_FTR_SECTION_IFSET(CPU_FTR_ARCH_207S) > * > * > > *****************************************************************************/ > > -.global kvmppc_hv_entry
I think this is okay. > -kvmppc_hv_entry: > +SYM_INNER_LABEL(kvmppc_hv_entry, SYM_L_LOCAL) The documentation for SYM_INNER_LABEL says it for labels inside a SYM function block, is that a problem? This is a function but doesn't have C calling convention, so asm annotation docs say that it should use SYM_CODE_START_LOCAL? BTW. why don't our _GLOBAL() macros use these SYM annotations? I haven't really looked into them. Thanks, Nick
