On Tue, 2008-07-15 at 17:24 +0400, Anton Vorontsov wrote: > On Tue, Jul 15, 2008 at 01:54:30PM +0100, Richard Purdie wrote: > > I don't have any issue with the driver itself, just the name which is > > going to confuse people no end. > > > > Can we come up with a better name for this driver please? [...] > > "openfirmware-led"? > > And this would be wrong, since this driver is for GPIO LEDs only, not > for all LEDs that OF can describe. In future there could be OF PWM LEDs > or something like this.
Ok, will these be a separate driver or combined into the gpio driver? > > I'm mainly concerned with the more user visible bits like the name of > > the .c file, the wording of the Kconfig option and the module > > description. We need to play down the GPIO bit and play up the > > openfirmware bindings bit. > > Hm... file name is leds-of-gpio.c, how could I play up the "of" bit more > than this? ;-) Spell out openfirmware :). I initially had no idea "of == openfirmware" and I suspect others won't either... > > As an example the Kconfig says "LED Support for GPIO connected LEDs" > > which its not, the bit about openfirmware bindings is in brackets and > > hence looks incidental. > > As for Kconfig, yeah.. probably I can improve the wording. How about > "OpenFirmware bindings for GPIO connected LEDs"? Would that work? Yes, thats better. I think basically we need to spell out OF a bit more. Its probably obvious to powerpc people but not everyone else. Cheers, Richard _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
