On Tue, 2022-12-20 at 18:16 +1100, Andrew Donnellan wrote: > plpks_confirm_object_flushed() uses the H_PKS_CONFIRM_OBJECT_FLUSHED > hcall > to check whether changes to an object in the Platform KeyStore have > been > flushed to non-volatile storage. > > The hcall returns two output values, the return code and the flush > status. > plpks_confirm_object_flushed() polls the hcall until either the flush > status has updated, the return code is an error, or a timeout has > been > exceeded. > > While we're still polling, the hcall is returning H_SUCCESS (0) as > the > return code. In the timeout case, this means that upon exiting the > polling > loop, rc is 0, and therefore 0 is returned to the user. > > Handle the timeout case separately and return ETIMEDOUT if triggered. > > Fixes: 2454a7af0f2a ("powerpc/pseries: define driver for Platform > KeyStore") > Reported-by: Benjamin Gray <bg...@linux.ibm.com> > Signed-off-by: Andrew Donnellan <a...@linux.ibm.com>
Tested-by: Russell Currey <rus...@russell.cc> Reviewed-by: Russell Currey <rus...@russell.cc>