On Thu, 2022-11-03 at 11:39 +1100, Benjamin Gray wrote:
> > By the way, 'extern' keyword is pointless and deprecated for
> > functions
> > prototypes, please don't add new ones, even if other historical
> > prototypes have one.
>
> This and the above commented parts match the style of the surrounding
> implementations. For example,
>
> static inline void local_flush_tlb_mm(struct mm_struct *mm)
> {
> if (radix_enabled())
> return radix__local_flush_tlb_mm(mm);
> return hash__local_flush_tlb_mm(mm);
> }
>
> I am not going to add code that is inconsistent with the surrounding
> code. That just causes confusion later down the line when readers
> wonder why this function is special compared to the others. If it
> needs
> to use modern style, then I would be happy to include a patch that
> modernises the surrounding code first.
This series would be a good opportunity to clean the rest of that file
up; either way, as Christophe says we should avoid adding new uses
given that people have started actively trying to clean up the use of
the extern keyword.
--
Andrew Donnellan OzLabs, ADL Canberra
a...@linux.ibm.com IBM Australia Limited
