Teardown hypervisor mode if vector slot setup fails in order to avoid
leaking any allocations done by init_hyp_mode().

Fixes: b881cdce77b4 ("KVM: arm64: Allocate hyp vectors statically")
Signed-off-by: Sean Christopherson <sea...@google.com>
---
 arch/arm64/kvm/arm.c | 15 ++++++++-------
 1 file changed, 8 insertions(+), 7 deletions(-)

diff --git a/arch/arm64/kvm/arm.c b/arch/arm64/kvm/arm.c
index 0c328af064dd..73644def7780 100644
--- a/arch/arm64/kvm/arm.c
+++ b/arch/arm64/kvm/arm.c
@@ -2232,18 +2232,18 @@ int kvm_arch_init(void *opaque)
        err = kvm_init_vector_slots();
        if (err) {
                kvm_err("Cannot initialise vector slots\n");
-               goto out_err;
-       }
-
-       err = init_subsystems();
-       if (err)
                goto out_hyp;
+       }
+
+       err = init_subsystems();
+       if (err)
+               goto out_subs;
 
        if (!in_hyp_mode) {
                err = finalize_hyp_mode();
                if (err) {
                        kvm_err("Failed to finalize Hyp protection\n");
-                       goto out_hyp;
+                       goto out_subs;
                }
        }
 
@@ -2257,8 +2257,9 @@ int kvm_arch_init(void *opaque)
 
        return 0;
 
-out_hyp:
+out_subs:
        hyp_cpu_pm_exit();
+out_hyp:
        if (!in_hyp_mode)
                teardown_hyp_mode();
 out_err:
-- 
2.38.1.431.g37b22c650d-goog

Reply via email to