On Fri, Sep 16, 2022, at 7:32 AM, Rohan McLure wrote: > As reported[1] by Arnd, the arch-specific fadvise64_64 and fallocate > compatibility handlers assume parameters are passed with 32-bit > big-endian ABI. This affects the assignment of odd-even parameter pairs > to the high or low words of a 64-bit syscall parameter. > > Fix fadvise64_64 fallocate compat handlers to correctly swap upper/lower > 32 bits conditioned on endianness. > > A future patch will replace the arch-specific compat fallocate with an > asm-generic implementation. This patch is intended for ease of > back-port. > > [1]: > https://lore.kernel.org/all/[email protected]/ > > Fixes: 57f48b4b74e7 ("powerpc/compat_sys: swap hi/lo parts of 64-bit > syscall args in LE mode") > Reported-by: Arnd Bergmann <[email protected]> > Signed-off-by: Rohan McLure <[email protected]>
Looks good, thanks! Reviewed-by: Arnd Bergmann <[email protected]> Cc: [email protected] # v5.12+
