>> +static inline bool pmd_user_accessible_page(pmd_t pmd) >> +{ >> + return pmd_is_leaf(pmd) && pmd_present(pmd) >> + && pte_user(pmd_pte(pmd)); > > The && goes on previous line.
> By the way, there is a great tool that can help you : > > $ ./arch/powerpc/tools/checkpatch.sh --strict -g HEAD~ Thank you. Yes I should be using --strict with checkpatch. > >> +} >> + >> +#else >> + >> +static inline bool pmd_user_accessible_page(pmd_t pmd) >> +{ >> + BUG(); > > Can you use BUILD_BUG() instead ? As it stands, p{m,u}d_user_accessible page is invoked by __page_table_check_p{m,u}d_{set,clear}. So unfortunately this function will have to be compiled, but its body could be replaced with a WARN() and return false on 32-bit.