.org>, Robert Jones <rjo...@gateworks.com>, George Joseph
<george.jos...@fairview5.com>, Vincent Knecht <vincent.kne...@mailoo.org>,
Robin van der Gracht <ro...@protonic.nl>, Randy Dunlap <rdun...@infradead.org>,
linux-st...@st-md-mailman.stormreply.com, Michael Tretter
<m.tret...@pengutronix.de>, Geert Uytterhoeven <ge...@linux-m68k.org>, Phong LE
<p...@baylibre.com>, Daniel Beer <daniel.b...@igorinstitute.com>, Krzysztof
Opasiak <k.opas...@samsung.com>, Bjorn Andersson <bjorn.anders...@linaro.org>,
linux-cry...@vger.kernel.org, Pengutronix Kernel Team <ker...@pengutronix.de>,
Heungjun Kim <riverful....@samsung.com>, Hans Verkuil
<hverkuil-ci...@xs4all.nl>, David Lin <ctl...@nuvoton.com>, Vladimir Oltean
<olte...@gmail.com>, David Rhodes <david.rho...@cirrus.com>, Claudiu Beznea
<claudiu.bez...@microchip.com>, Jean-Baptiste Maneyrol
<jean-baptiste.maney...@tdk.com>, Alexandre Belloni
<alexandre.bell...@bootlin.com>, Dan Robertson <d...@dlrobertson.com>, Martyn
Welch <martyn.welch@coll
abora.co.uk>, Jiri Slaby <jirisl...@kernel.org>, devicet...@vger.kernel.org,
David Airlie <airl...@linux.ie>, Jon Nettleton <jon.nettle...@gmail.com>,
Srinivas Pandruvada <srinivas.pandruv...@linux.intel.com>, Marco Felsch
<m.fel...@pengutronix.de>, Wim Van Sebroeck <w...@linux-watchdog.org>,
Sebastian Reichel <s...@kernel.org>, Max Filippov <jcmvb...@gmail.com>, "Lad,
Prabhakar" <prabhakar.cse...@gmail.com>, Thierry Reding
<thierry.red...@gmail.com>, linux-...@vger.kernel.org, Martiros Shakhzadyan
<v...@vrzh.net>, Guenter Roeck <gro...@chromium.org>, Matthias Schwarzott
<z...@gentoo.org>, Sylwester Nawrocki <s.nawro...@samsung.com>, Eric Dumazet
<eduma...@google.com>, Marek =?ISO-8859-1?Q?Beh�n?= <ka...@kernel.org>, Saranya
Gopal <saranya.go...@intel.com>, Lars-Peter Clausen <l...@metafoo.de>, Corey
Minyard <miny...@acm.org>, Evgeny Novikov <novi...@ispras.ru>, Frank Rowand
<frowand.l...@gmail.com>, Bartosz Golaszewski <b...@bgdev.pl>, Manivannan
Sadhasivam <m...@kernel.org>, Pierr
e-Louis Bossart <pierre-louis.boss...@linux.intel.com
>, Minghao Chi <chi.ming...@zte.com.cn>, linux-...@vger.kernel.org, Nathan
>Chancellor <nat...@kernel.org>, MyungJoo Ham <myungjoo....@samsung.com>,
>Charles Gorand <charles.gor...@effinnov.com>, Jagan Teki
><ja...@amarulasolutions.com>, Vijendar Mukunda <vijendar.muku...@amd.com>,
>Miguel Ojeda <oj...@kernel.org>, Kyungmin Park <kyungmin.p...@samsung.com>,
>Tianshu Qiu <tian.shu....@intel.com>, Martin Donnelly
><martin.donne...@ge.com>, Woojung Huh <woojung....@microchip.com>, Rudolf
>Marek <r.ma...@assembler.cz>, Charles Keepax <ckee...@opensource.cirrus.com>,
>linux-watch...@vger.kernel.org, Michael Hennerich
><michael.henner...@analog.com>, Ido Schimmel <ido...@nvidia.com>,
>acpi4asus-u...@lists.sourceforge.net, Simon Trimmer
><sim...@opensource.cirrus.com>, Ricard Wanderlof <rica...@axis.com>, Rikard
>Falkeborn <rikard.falkeb...@gmail.com>, Alex Deucher
><alexander.deuc...@amd.com>, Jiri Valek - 2N <va...@2n.cz>,
>linux-rpi-ker...@lists.infradead.org, Biju Das <biju.das...@bp.renesas.com>, Wa
yne Chang <way...@nvidia.com>, Chen-Yu Tsai <w...@csie.org>, Sing-Han Chen
<singh...@nvidia.com>, linux-arm-ker...@lists.infradead.org, Niklas
=?ISO-8859-1?Q?S�derlund?= <niklas.soderlund+rene...@ragnatech.se>, Hans de
Goede <hdego...@redhat.com>, Stephen Boyd <sb...@kernel.org>, Maslov Dmitry
<maslovdmi...@seeed.cc>, linux-g...@vger.kernel.org, Jens Frederich
<jfreder...@gmail.com>, Douglas Anderson <diand...@chromium.org>,
linux-me...@vger.kernel.org, "David S. Miller" <da...@davemloft.net>, Paul
Kocialkowski <paul.kocialkow...@bootlin.com>, Jarkko Sakkinen
<jar...@kernel.org>, linux-...@vger.kernel.org, Jacopo Mondi
<jacopo+rene...@jmondi.org>, Maxime Coquelin <mcoquelin.st...@gmail.com>, CGEL
ZTE <cgel....@gmail.com>, Colin Leroy <co...@colino.net>,
platform-driver-...@vger.kernel.org, linux-integr...@vger.kernel.org, Kevin
Tsai <kt...@capellamicro.com>, Pali =?ISO-8859-1?Q?Roh�r?= <p...@kernel.org>,
Jonathan Cameron <ji...@kernel.org>, Heiner Kallweit <hkallwe...@gmail.com>
, Daniel Palmer <dan...@0x0f.com>, Arec Kao <arec.kao
@intel.com>, Crt Mori <c...@melexis.com>, Jose Cazarin
<joseespir...@gmail.com>, Neil Armstrong <narmstr...@baylibre.com>,
linux-...@vger.kernel.org, Tom Rix <t...@redhat.com>, Michael Turquette
<mturque...@baylibre.com>, Peter Senna Tschudin <peter.se...@gmail.com>,
Benjamin Mugnier <benjamin.mugn...@foss.st.com>, Nuno =?ISO-8859-1?Q?S�?=
<nuno...@analog.com>, Jan-Simon Moeller <jansimon.moel...@gmx.de>, Wei Yongjun
<weiyongj...@huawei.com>, Laurent Pinchart <laurent.pinch...@ideasonboard.com>,
Andrzej Hajda <andrzej.ha...@intel.com>, Nikita Travkin <nik...@trvn.ru>,
Jasmin Jessich <jas...@anw.at>, Sam Ravnborg <s...@ravnborg.org>, Kevin
Cernekee <cerne...@chromium.org>, Alyssa Rosenzweig <aly...@rosenzweig.io>,
linux-...@vger.kernel.org, Daniel Thompson <daniel.thomp...@linaro.org>,
Florian Fainelli <f.faine...@gmail.com>, Lucas Tanure
<tanur...@opensource.cirrus.com>, Stefan Mavrodiev <ste...@olimex.com>,
Masahiro Yamada <masahi...@kernel.org>, Sylvain Petinot <sylvain.petinot@fos
s.st.com>, net...@vger.kernel.org, Kieran Bingham
<kieran.bing...@ideasonboard.com>, Jernej Skrabec <jernej.skra...@gmail.com>,
Xin Ji <x...@analogixsemi.com>, Seven Lee <w...@nuvoton.com>, Matt Ranostay
<matt.ranos...@konsulko.com>, Broadcom internal kernel review list
<bcm-kernel-feedback-l...@broadcom.com>, Adrien Grassein
<adrien.grass...@gmail.com>, Yang Yingliang <yangyingli...@huawei.com>,
chrome-platf...@lists.linux.dev, Mats Randgaard <matra...@cisco.com>, Paolo
Abeni <pab...@redhat.com>, Alexey Dobriyan <adobri...@gmail.com>, Joel Stanley
<j...@jms.id.au>, linux-in...@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
Lyude Paul <ly...@redhat.com>, Kees Cook <keesc...@chromium.org>, Uwe
=?ISO-8859-1?Q?Kleine-K�nig?= <u...@kleine-koenig.org>, Jonas Karlman
<jo...@kwiboo.se>, Yang Li <yang....@linux.alibaba.com>, Tim Harvey
<thar...@gateworks.com>, Jiri Kosina <ji...@kernel.org>, Akinobu Mita
<akinobu.m...@gmail.com>, Mark Gross <markgr...@kernel.org>, Richard Fitzgerald
<rf@op
ensource.cirrus.com>, Mark Brown <broo...@kernel.org>
, wengjianfeng <wengjianf...@yulong.com>, Maxime Ripard <max...@cerno.tech>,
Sven Peter <s...@svenpeter.dev>, Martin Kepplinger <mart...@posteo.de>,
openipmi-develo...@lists.sourceforge.net, Mauro Carvalho Chehab
<mche...@kernel.org>, Benson Leung <ble...@chromium.org>, "Daniel W. S.
Almeida" <dwlsalme...@gmail.com>, Chiranjeevi Rapolu
<chiranjeevi.rap...@intel.com>, Alessandro Zummo <a.zu...@towertech.it>,
linux-hw...@vger.kernel.org, Felipe Balbi <ba...@kernel.org>, Stephan Gerhold
<step...@gerhold.net>, Support Opensource <support.opensou...@diasemi.com>,
Alexandru Ardelean <ardeleana...@gmail.com>, Dmitry Torokhov
<dmitry.torok...@gmail.com>, Marc Hulsman <m.huls...@tudelft.nl>, Corentin
Chary <corentin.ch...@gmail.com>, Stephen Kitt <st...@sk2.org>, Daniel Scally
<djrsca...@gmail.com>, linux-fb...@vger.kernel.org, Andrey Ryabinin
<ryabinin....@gmail.com>, Arnd Bergmann <a...@arndb.de>, Kirill Shilimanov
<kirill.shilima...@huawei.com>, Sakari Ailus <sakari.ai...@linux.intel.com>,
patc...@opensource.cirrus.com, Zheng Yongjun <zhengyongj...@huawei.com>,
Alejandro Tafalla <atafa...@dnyon.com>, Peter Rosin <p...@axentia.se>, Arnaud
Ferraris <arnaud.ferra...@collabora.com>, Hector Martin <mar...@marcan.st>,
Vignesh Raghavendra <vigne...@ti.com>, Nick Dyer <n...@shmanahar.org>, Greg
Kroah-Hartman <gre...@linuxfoundation.org>, Tony Lindgren <t...@atomide.com>,
Alexandre Torgue <alexandre.tor...@foss.st.com>, Takashi Iwai <ti...@suse.com>,
Paul Cercueil <p...@crapouillou.net>, George McCollister
<george.mccollis...@gmail.com>, Mac Chiang <mac.chi...@intel.com>, Antoniu
Miclaus <antoniu.micl...@analog.com>, Alexander Potapenko <gli...@google.com>,
linux-stag...@lists.linux.dev, Adam Ford <aford...@gmail.com>, Peter Huewe
<peterhu...@gmx.de>, unglinuxdri...@microchip.com, Lee Jones
<lee.jo...@linaro.org>, linux-...@lists.infradead.org, Alexey Khoroshilov
<khoroshi...@ispras.ru>, Marek Vasut <ma...@denx.de>, Yizhuo
<yzhai...@ucr.edu>, alsa-de...@alsa-project.org, Vinc
enzo Frascino <vincenzo.frasc...@arm.com>, Eric Piel
<eric.p...@tremplin-utc.net>, Herbert Xu <herb...@gondor.apana.org.au>, Tobias
Schrammm <t.schr...@manjaro.org>, Richard Weinberger <rich...@nod.at>, Tomasz
Duszynski <tdusz...@gmail.com>, Janusz Krzysztofik <jmkrzy...@gmail.com>,
Russell King <li...@armlinux.org.uk>, linux-...@vger.kernel.org, Jason
Gunthorpe <j...@ziepe.ca>, Thomas Zimmermann <tzimmerm...@suse.de>, Bastien
Nocera <had...@hadess.net>, Jingoo Han <jingooh...@gmail.com>, Jakub Kicinski
<k...@kernel.org>, Vivien Didelot <vivien.dide...@gmail.com>, Shawn Tu
<shawnx...@intel.com>, Leon Luo <le...@leopardimaging.com>, Yan Lei
<yan_...@dahuatech.com>, Akihiro Tsukada <tsk...@gmail.com>, Tudor Ambarus
<tudor.amba...@microchip.com>, Dmitry Rokosov <ddroko...@sberdevices.ru>,
Oliver Graute <oliver.gra...@kococonnector.com>, Alistair Francis
<alist...@alistair23.me>, Dongliang Mu <mudonglianga...@gmail.com>, Jonathan
=?ISO-8859-1?Q?Neusch�fer?= <j.neuschae...@gmx.net>, Eduardo Valentin
<edubez...@gmail.com>, Rui Miguel Silva
<rmf...@gmail.com>, Michael Srba <michael.s...@seznam.cz>, Rob Herring
<robh...@kernel.org>, linux-media...@lists.infradead.org, Fabio Estevam
<feste...@gmail.com>, Matthias Brugger <matthias....@gmail.com>,
kasan-...@googlegroups.com, "Paul J. Murphy" <paul.j.mur...@intel.com>, Nicola
Lunghi <nick83...@gmail.com>, Daniele Alessandrelli
<daniele.alessandre...@intel.com>, Dmitry Vyukov <dvyu...@google.com>, Ramesh
Shanmugasundaram <rasha...@gmail.com>, Liam Girdwood <lgirdw...@gmail.com>,
Juerg Haefliger <jue...@gmail.com>, Oder Chiou <oder_ch...@realtek.com>,
Shengjiu Wang <shengjiu.w...@nxp.com>, Nicolas Ferre
<nicolas.fe...@microchip.com>, Robert Foss <robert.f...@linaro.org>, Krzysztof
Kozlowski <krzysztof.kozlow...@linaro.org>, Daniel Vetter <dan...@ffwll.ch>,
Alvin =?UTF-8?Q?Šipraga?= <a...@bang-olufsen.dk>, Luca Ceresoli
<l...@lucaceresoli.net>, =?ISO-8859-1?Q?Jos�_Exp�sito?=
<jose.exposit...@gmail.com>, Johannes Berg <johan...@sipsolutions.net>, Colin
Ian King <colin
.k...@intel.com>, Maximilian Luz <luzmaximilian@gmail
.com>, Helge Deller <del...@gmx.de>, Lucas Stach <l.st...@pengutronix.de>
Errors-To: linuxppc-dev-bounces+archive=mail-archive....@lists.ozlabs.org
Sender: "Linuxppc-dev"
<linuxppc-dev-bounces+archive=mail-archive....@lists.ozlabs.org>
Hi Uwe,
Looks good - just one minor change for the mctp-i2c driver, but only
worthwhile if you end up re-rolling this series for other reasons:
> -static int mctp_i2c_remove(struct i2c_client *client)
> +static void mctp_i2c_remove(struct i2c_client *client)
> {
> struct mctp_i2c_client *mcli = i2c_get_clientdata(client);
> struct mctp_i2c_dev *midev = NULL, *tmp = NULL;
> @@ -1000,7 +1000,6 @@ static int mctp_i2c_remove(struct i2c_client *client)
> mctp_i2c_free_client(mcli);
> mutex_unlock(&driver_clients_lock);
> /* Callers ignore return code */
> - return 0;
> }
The comment there no longer makes much sense, I'd suggest removing that
too. Either way:
Reviewed-by: Jeremy Kerr <j...@codeconstruct.com.au>
Cheers,
Jeremy
