Hi Ash,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on powerpc/next]
[also build test WARNING on robh/for-next]
[cannot apply to mpe/next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    
https://github.com/intel-lab-lkp/linux/commits/Ash-Logan/dt-bindings-wiiu-Document-the-Nintendo-Wii-U-devicetree/20220622-221056
base:   https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git next
config: powerpc-randconfig-c003-20220626 
(https://download.01.org/0day-ci/archive/20220627/202206271019.yen99lfz-...@intel.com/config)
compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project 
b0d6dd3905db145853c7c744ac92d49b00b1fa20)
reproduce (this is a W=1 build):
        wget 
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O 
~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install powerpc cross compiling tool for clang build
        # apt-get install binutils-powerpc-linux-gnu
        # 
https://github.com/intel-lab-lkp/linux/commit/533a7cf49cc00c4eaafd2afee5ecd9e23bac99f2
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review 
Ash-Logan/dt-bindings-wiiu-Document-the-Nintendo-Wii-U-devicetree/20220622-221056
        git checkout 533a7cf49cc00c4eaafd2afee5ecd9e23bac99f2
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 
O=build_dir ARCH=powerpc SHELL=/bin/bash arch/powerpc/platforms/wiiu/ 
drivers/usb/misc/

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <l...@intel.com>

All warnings (new ones prefixed by >>):

>> arch/powerpc/platforms/wiiu/latte-pic.c:155:14: warning: no previous 
>> prototype for function 'latte_pic_get_irq' [-Wmissing-prototypes]
   unsigned int latte_pic_get_irq(struct irq_domain *h)
                ^
   arch/powerpc/platforms/wiiu/latte-pic.c:155:1: note: declare 'static' if the 
function is not intended to be used outside of this translation unit
   unsigned int latte_pic_get_irq(struct irq_domain *h)
   ^
   static 
   1 warning generated.


vim +/latte_pic_get_irq +155 arch/powerpc/platforms/wiiu/latte-pic.c

   150  
   151  /*
   152   * Determinate if there are interrupts pending
   153   * Checks AHBALL (0-32) and AHBLT (32-64)
   154   */
 > 155  unsigned int latte_pic_get_irq(struct irq_domain *h)
   156  {
   157          struct lt_pic *pic = *this_cpu_ptr(&lt_pic_cpu);
   158          u32 irq_status, irq;
   159  
   160          /* Check AHBALL first */
   161          irq_status = in_be32(&pic->ahball_icr) & 
in_be32(&pic->ahball_imr);
   162  
   163          if (irq_status == 0) {
   164                  /* Try AHBLT */
   165                  irq_status =
   166                          in_be32(&pic->ahblt_icr) & 
in_be32(&pic->ahblt_imr);
   167                  if (irq_status == 0)
   168                          return 0; /* No IRQs pending */
   169  
   170                  /* AHBLT is mapped above 32 (LATTE_AHBALL_NR_IRQS) */
   171                  irq = __ffs(irq_status) + LATTE_AHBALL_NR_IRQS;
   172                  return irq_linear_revmap(h, irq);
   173          }
   174  
   175          irq = __ffs(irq_status);
   176          return irq_linear_revmap(h, irq);
   177  }
   178  

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

Reply via email to