Le 28/05/2022 à 10:05, Christian Zigotzky a écrit :
> On 27 May 2022 at 04:23 am, Rob Herring wrote:
>> The issue is in drivers/usb/host/fsl-mph-dr-of.c which copies the
>> resources to a child platform device. Can you try the following
>> change:
>>
>> diff --git a/drivers/usb/host/fsl-mph-dr-of.c
>> b/drivers/usb/host/fsl-mph-dr-of.c
>> index 44a7e58a26e3..47d9b7be60da 100644
>> --- a/drivers/usb/host/fsl-mph-dr-of.c
>> +++ b/drivers/usb/host/fsl-mph-dr-of.c
>> @@ -80,8 +80,6 @@ static struct platform_device
>> *fsl_usb2_device_register(
>> const char *name, int id)
>> {
>> struct platform_device *pdev;
>> - const struct resource *res = ofdev->resource;
>> - unsigned int num = ofdev->num_resources;
>> int retval;
>>
>> pdev = platform_device_alloc(name, id);
>> @@ -106,11 +104,7 @@ static struct platform_device
>> *fsl_usb2_device_register(
>> if (retval)
>> goto error;
>>
>> - if (num) {
>> - retval = platform_device_add_resources(pdev, res, num);
>> - if (retval)
>> - goto error;
>> - }
>> + pdev->dev.of_node = ofdev->dev.of_node;
>>
>> retval = platform_device_add(pdev);
>> if (retval)
> Hi Rob,
>
> Thanks a lot for your patch! :-)
>
> First attempt with the latest git kernel:
>
> patching file a/drivers/usb/host/fsl-mph-dr-of.c
> Hunk #1 FAILED at 80.
> Hunk #2 FAILED at 106.
> 2 out of 2 hunks FAILED -- saving rejects to file
> a/drivers/usb/host/fsl-mph-dr-of.c.rej
>
> I created a new patch with your modifications. (see attachment)
>
> Unfortunately I can't test it. The git kernel doesn't compile currently.
>
> powerpc-linux-gnu-ld: net/rds/tcp_stats.o:(.bss+0x0): multiple
> definition of `____cacheline_aligned'; init/version.o:(.bss+0x0): first
> defined here
...
> make: *** [Makefile:1160: vmlinux] Error 1
>
> @All
> Could you please check the multiple definition of `____cacheline_aligned'?
>
Fix at
https://patchwork.ozlabs.org/project/linuxppc-dev/patch/20220527112035.2842155-1-...@ellerman.id.au/
Christophe
