On Fri, Jun 27, 2008 at 04:10:17PM -0500, Kumar Gala wrote:
> Added DMA nodes for the elo/elo-plus DMA engines.
> 
> Renamed the interrupt controller alias in mpc832x_rdb.dts to ipic so that
> its the same as all the other boards.
> 
> Signed-off-by: Kumar Gala <[EMAIL PROTECTED]>

[snip]
> diff --git a/arch/powerpc/boot/dts/asp834x-redboot.dts 
> b/arch/powerpc/boot/dts/asp834x-redboot.dts
> index 972cf78..8b1bb0e 100644
> --- a/arch/powerpc/boot/dts/asp834x-redboot.dts
> +++ b/arch/powerpc/boot/dts/asp834x-redboot.dts
> @@ -118,6 +118,41 @@
>                       mode = "cpu";
>               };
> 
> +             [EMAIL PROTECTED] {
> +                     #address-cells = <1>;
> +                     #size-cells = <1>;
> +                     compatible = "fsl,mpc8347-dma", "fsl,elo-dma";
> +                     reg = <0x82a8 4>;
> +                     ranges = <0 0x8100 0x1a8>;
> +                     interrupt-parent = <&ipic>;
> +                     interrupts = <71 8>;
> +                     cell-index = <0>;

What's the cell-index in these nodes used to index?  Given the
confusion there's been about the proper use of this property, a
comment indicating which shared registers this is used to index is
probably a good idea.

-- 
David Gibson                    | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au  | minimalist, thank you.  NOT _the_ _other_
                                | _way_ _around_!
http://www.ozlabs.org/~dgibson
_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev

Reply via email to