On Wed, 30 Mar 2022 06:55:26 +0000 Christophe Leroy <christophe.le...@csgroup.eu> wrote:
> > Small nit. Please order the includes in "upside-down x-mas tree" fashion: > > > > #include <linux/jump_label.h> > > #include <linux/suspend.h> > > #include <linux/ftrace.h> > > #include <linux/slab.h> > > > > That's the first time I get such a request. Usually people request > #includes to be in alphabetical order so when I see a file that has > headers in alphabetical order I try to not break it, but here that was > not the case so I put it at the end of the list. This is something that Ingo Molnar started back in 2009 or so. And I do find it easier on the eyes ;-) I may be the only one today trying to keep it (albeit poorly). It's not a hard requirement, but I find it makes the code look more like art, which it is :-D > > I'll send v3 Thanks, -- Steve
