On Wed, Feb 23, 2022 at 1:34 AM Christophe Leroy <christophe.le...@csgroup.eu> wrote: > > > > Le 02/06/2020 à 07:27, Jordan Niethe a écrit : > > Currently prefixed instructions are treated as two word instructions by > > show_user_instructions(), treat them as a single instruction. '<' and > > '>' are placed around the instruction at the NIP, and for prefixed > > instructions this is placed around the prefix only. Make the '<' and '>' > > wrap the prefix and suffix. > > > > Currently showing a prefixed instruction looks like: > > fbe1fff8 39200000 06000000 a3e30000 <04000000> f7e40000 ebe1fff8 4e800020 > > > > Make it look like: > > 0xfbe1fff8 0x39200000 0x06000000 0xa3e30000 <0x04000000 0xf7e40000> > > 0xebe1fff8 0x4e800020 0x00000000 0x00000000 > > Is it really needed to have the leading 0x ? You are right, that is not consistent with how instructions are usually dumped. That formatting comes from ppc_inst_as_str(), which when mpe merged he removed the leading 0x.
> > And is there a reason for that two 0x00000000 at the end of the new line > that we don't have at the end of the old line ? No, that is wrong. > > This is initially split into 8 instructions per line in order to fit in > a 80 columns screen/terminal. > > Could you make it such that it still fits within 80 cols ? Sure that makes sense. > > Same for patch 4 on show_user_instructions() > > Christophe
