Hi, On Friday 20 June 2008 10:55, Matvejchikov Ilya wrote: > >> > diff --git a/drivers/net/fs_enet/mac-fcc.c b/drivers/net/fs_enet/mac-fcc.c > >> > index ce40cf9..1a95cf1 100644 > >> > --- a/drivers/net/fs_enet/mac-fcc.c > >> > +++ b/drivers/net/fs_enet/mac-fcc.c > >> > @@ -464,6 +464,9 @@ static void restart(struct net_device *dev) > >> > C32(fccp, fcc_fpsmr, FCC_PSMR_FDE | FCC_PSMR_LPB); > >> > > >> > S32(fccp, fcc_gfmr, FCC_GFMR_ENR | FCC_GFMR_ENT); > >> > + > >> > + /* Restore multicast and promiscous settings */ > >> > + set_multicast_list(dev); > >> > } > > Is it right to call set_multicast_list() after turning on transmitter > and receiver? May be swap this lines around?
I'm not sure if that will make a difference, but you're right, restoring the multicast and promiscuous settings is better done before turning the receiver and transmitter on. I'll send a new patch. -- Laurent Pinchart CSE Semaphore Belgium Chaussee de Bruxelles, 732A B-1410 Waterloo Belgium T +32 (2) 387 42 59 F +32 (2) 387 42 75
pgpOS8CP0yMhx.pgp
Description: PGP signature
_______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
