On Fri, 14 Jan 2022 14:13:16 +1100 Michael Ellerman wrote:
> Since commit adeef3e32146 ("net: constify netdev->dev_addr") the bmac
> driver no longer builds with the following errors (pmac32_defconfig):
>
> linux/drivers/net/ethernet/apple/bmac.c: In function ‘bmac_probe’:
> linux/drivers/net/ethernet/apple/bmac.c:1287:20: error: assignment of
> read-only location ‘*(dev->dev_addr + (sizetype)j)’
> 1287 | dev->dev_addr[j] = rev ? bitrev8(addr[j]): addr[j];
> | ^
>
> Fix it by making the modifications to a local macaddr variable and then
> passing that to eth_hw_addr_set().
>
> We don't use the existing addr variable because the bitrev8() would
> mutate it, but it is already used unreversed later in the function.
>
> Signed-off-by: Michael Ellerman <m...@ellerman.id.au>
Reviewed-by: Jakub Kicinski <k...@kernel.org>
Thank you!
