Hi Segher, On Thu, 4 Nov 2021 06:33:51 -0500 Segher Boessenkool <seg...@kernel.crashing.org> wrote: > > On Thu, Nov 04, 2021 at 09:06:56PM +1100, Stephen Rothwell wrote: > > On Thu, 4 Nov 2021 14:17:09 +0800 davidcomponent...@gmail.com wrote: > > > From: Yang Guang <yang.gua...@zte.com.cn> > > > > > > Use the macro 'swap()' defined in 'include/linux/minmax.h' to avoid > > > opencoding it. > > > > So if swap() is in the above include file, then you should include it. > > It is included from kernel.h already (which is included from delay.h).
And that becomes a pain when include files get "cleaned up". :-(
$ grep kernel.h include/linux/delay.h
$
See commit
300424acf349 ("include/linux/delay.h: replace kernel.h with the necessary
inclusions")
currently pending the Andrew Morton's patch queue (the above is a
linux-next commit).
--
Cheers,
Stephen Rothwell
pgpxfimCVZ5A3.pgp
Description: OpenPGP digital signature
